internal/manifest: add tiering info to blob references #5745
Open
annrpom wants to merge 1 commit intocockroachdb:masterfrom
Open
internal/manifest: add tiering info to blob references #5745annrpom wants to merge 1 commit intocockroachdb:masterfrom
annrpom wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
annrpom
force-pushed
the
blob-tiering-attr
branch
from
0dd824f to
cf5c230
Compare
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
annrpom
force-pushed
the
blob-tiering-attr
branch
2 times, most recently
from
b035aa9 to
8959857
Compare
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
Previously, blob references did not store which tier (hot or cold) the blob file was written to. This patch adds a Tier field to both BlobReference and PhysicalBlobFile. The tier is now persisted in version edits using new tags (tagNewBlobFile2 and customTagBlobReferences3) that include tier information in the encoding. Decoding of old formats defaults to HotTier for backward compatibility. WriterOptions.BlobReferenceTierGetter is replaced with BlobReferenceTiers, a slice indexed by reference ID.
annrpom
force-pushed
the
blob-tiering-attr
branch
from
8959857 to
a5ea66f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, blob references did not store which tier (hot or cold) the blob
file was written to.
This patch adds a Tier field to both BlobReference and PhysicalBlobFile.
The tier is now persisted in version edits using new tags (tagNewBlobFile2 and
customTagBlobReferences3) that include tier information in the encoding.
Decoding of old formats defaults to HotTier for backward compatibility.
WriterOptions.BlobReferenceTierGetter is replaced with BlobReferenceTiers,
a slice indexed by reference ID.