see if I can fix the example orms issue#153
Closed
angles-n-daemons wants to merge 1 commit intocockroachdb:masterfrom
Closed
see if I can fix the example orms issue#153angles-n-daemons wants to merge 1 commit intocockroachdb:masterfrom
angles-n-daemons wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
rafiss
reviewed
Sep 29, 2025
| func getVersionFromDB(t *testing.T, db *sql.DB) *version.Version { | ||
| t.Helper() | ||
| var crdbVersion string | ||
| if _, err := db.Exec(`SET allow_unsafe_internals=true`); err != nil { |
Contributor
There was a problem hiding this comment.
this will cause issues when this test is executed against older versions of CRDB that don't have this setting.
i wonder if we could just change the select query below to do SHOW crdb_version instead, with some additional parsing.
root@localhost:26257/defaultdb> SELECT value FROM crdb_internal.node_build_info where field = 'Version';
value
-----------------------
v25.4.0-alpha.2-dev
(1 row)
Time: 1ms total (execution 1ms / network 0ms)
root@localhost:26257/defaultdb> show crdb_version;
crdb_version
----------------------------------------------------------------------------------------------
CockroachDB CCL v25.4.0-alpha.2-dev (darwin arm64, built , go1.23.12 X:nocoverageredesign)
(1 row)
Contributor
Author
There was a problem hiding this comment.
That's a great idea, let me see if that works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.