sql: add pgcode for exclude_data_from_backup inbound FK error #161474
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when attempting to set `exclude_data_from_backup` on a table with inbound foreign key constraints, the error was raised without a proper pgcode (defaulting to XXUUU). This made it difficult for the schemachange workload to handle the error appropriately. This change adds `pgcode.ObjectNotInPrerequisiteState` (55000) to the error in both the legacy and declarative schema changers, and updates the schemachange workload to expect this error as a potential execution error when setting the `exclude_data_from_backup` storage parameter. Fixes: cockroachdb#161167 Release note: None
Member
|
This change is |
rafiss
requested review from
golgeek and
nameisbhaskar
and removed request for
a team
Collaborator
Author
|
tftr! bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when attempting to set
exclude_data_from_backupon a table with inbound foreign key constraints, the error was raised without a proper pgcode (defaulting to XXUUU). This made it difficult for the schemachange workload to handle the error appropriately.This change adds
pgcode.ObjectNotInPrerequisiteState(55000) to the error in both the legacy and declarative schema changers, and updates the schemachange workload to expect this error as a potential execution error when setting theexclude_data_from_backupstorage parameter.Fixes: #161167
Release note: None