Skip to content

Convert reagent grinder to TGUI#11627

Merged
MistChristmas merged 2 commits intocmss13-devs:masterfrom
rattybag:feature/reagent-grinder-tgui
Feb 6, 2026
Merged

Convert reagent grinder to TGUI#11627
MistChristmas merged 2 commits intocmss13-devs:masterfrom
rattybag:feature/reagent-grinder-tgui

Conversation

@rattybag
Copy link
Contributor

About the pull request

Convert the reagent grinder interface to TGUI from the old browser system.

Explain why it's good for the game

I wanted to make it so that the reagent grinder window closes when you step away from it (and also does not reopen even after you have stepped away), but it wasn't possible with the old system, so I have converted it to TGUI to achieve this.

Testing Photographs and Procedure

I comprehensively tested by grinding, juicing and bottling when connected and disconnected from a smartfridge.

https://youtu.be/H5Et41APNSU

Changelog

🆑
refactor: refactored reagent grinder to use TGUI
ui: reagent grinder interface now uses TGUI
/:cl:

@github-project-automation github-project-automation bot moved this to Awaiting Review in Review Backlog Jan 26, 2026
@cmss13-ci cmss13-ci bot added UI deletes nanoui/html Refactor Make the code harder to read size/L Denotes a PR that changes 200-799 lines, ignoring generated files. labels Jan 26, 2026
Copy link
Contributor

@MistChristmas MistChristmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise, the iteratation breaking when it finds something not allowed should probably be moved to continuing. Seeing as it doesn't stop the grindrer from processing. Especially noticable on the Juicing function.

@github-project-automation github-project-automation bot moved this from Awaiting Review to Changes Requested in Review Backlog Jan 30, 2026
- Refactor deprecated  Window.Content scrollable to instead have a wrapped Section with scrollable
- Refactor deprecated button content
@rattybag
Copy link
Contributor Author

rattybag commented Feb 4, 2026

Functionality wise, the iteratation breaking when it finds something not allowed should probably be moved to continuing. Seeing as it doesn't stop the grindrer from processing. Especially noticable on the Juicing function.

Thanks for the review, addressed all the points you made:

  • Continue instead of break when juicing/grinding non allowed items
  • Refactor deprecated Window.Content scrollable to instead have a wrapped Section with scrollable
  • Refactor deprecated button content

@github-project-automation github-project-automation bot moved this from Changes Requested to Partially Approved / Mergeable in Review Backlog Feb 5, 2026
@MistChristmas MistChristmas added this pull request to the merge queue Feb 6, 2026
Merged via the queue into cmss13-devs:master with commit 34dfbc4 Feb 6, 2026
25 checks passed
@github-project-automation github-project-automation bot moved this from Partially Approved / Mergeable to Merged in Review Backlog Feb 6, 2026
cmss13-ci bot added a commit that referenced this pull request Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Make the code harder to read size/L Denotes a PR that changes 200-799 lines, ignoring generated files. UI deletes nanoui/html

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

2 participants