Skip to content

Conversation

@jeremiedbb
Copy link
Contributor

@jeremiedbb jeremiedbb commented Mar 13, 2025

This workflow should not run on forks and is annoying because github sends a notification each time you push to fork to tell you that it failed.

@@ -1,4 +1,4 @@
name: Publish Python 🐍 distribution 📦 to PyPI and TestPyPI
name: Publish cloudpickle 🥒 distribution 📦 to PyPI and TestPyPI
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow doesn't publish Python but cloudpickle :)
Result of a quick copy paste.

with:
name: python-package-distributions
path: dist/
retention-days: 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by defaults artifacts are kept 90 days. For this workflow we only need them during the workflow run and 1 day is the minimum

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and the pickle emoji in particular.

@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.73%. Comparing base (8b82151) to head (659378e).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (8b82151) and HEAD (659378e). Click for more details.

HEAD has 18 uploads less than BASE
Flag BASE (8b82151) HEAD (659378e)
19 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #559       +/-   ##
===========================================
- Coverage   96.34%   84.73%   -11.62%     
===========================================
  Files           3        2        -1     
  Lines         575      570        -5     
  Branches      121      102       -19     
===========================================
- Hits          554      483       -71     
- Misses         11       69       +58     
- Partials       10       18        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogrisel ogrisel merged commit 7ba9e61 into cloudpipe:master Mar 14, 2025
26 of 27 checks passed
tomMoral pushed a commit to tomMoral/cloudpickle that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants