Open
Conversation
A better solution to this should be possible; this just elides the option-passing from Maruku invocations on jruby/win. Not very DRY, but gets the point across.
|
Maruku also supports options, but they are different. Please try to revert your changes (except win32|java) and pass to your toto config: set :markdown, {}Alternative way (which I prefer) is to improve the way Markdown.new is being called. I don't understand why it passes Markdown.new(text.to_s.strip, *(options.eql?(true) ? [] : options)).to_htmlwith Markdown.new(text.to_s.strip, *(options.eql?(true) ? {} : options)).to_htmlI believe both variants will help you. Unfortunately I can't test by myself as Win32 and JRuby are out of scope of waht I'm interested in, and I have neither Win32 system nor JRuby :)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toto is great! I wanted to run toto under a bare JRuby rackup, which generally just seems to need the maruku support already added in for Win32. The first of the 2 commits in this fork does that. But I was not able to get maruku to work with the same option passing behavior as Markdown, so the second commit disables it; this might be a bad idea; at least it could be done prettier. But it worked, and Dorothy's been deployed to an app server. Let me know if there is anything else I can do to get JRuby support included upstream. Thanks!