made possible to append extra response http headers in PerformServerUpgrade stage #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made response header ended up before OnWsConnecting so we can append extra handshake header to response
Author
|
some websocket protocol has extra handshake headers,we need deal with append some extra response http headers in PerformServerUpgrade stage,but currentlly netcoreserver don't has a mechanism to do this,so we can adjust SetBody in PerformServerUpgrade to after OnWsConnecting so can be made possible append extra http header in OnWsConnecting event. |
lifeengines
changed the title
|
make sense, it seems to be the perfect answer to #328 |
stratdev3
added a commit
to stratdev3/SimpleW
that referenced
this pull request
Apr 21, 2025
…rmServerUpgrade stage (#31) PR by [lifeengines](chronoxor/NetCoreServer#297) to fix [bramley-jetcharge issue](chronoxor/NetCoreServer#328)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made response header ended up before OnWsConnecting so we can append extra handshake header to response