Conversation
123-komal
force-pushed
the
feature-permission
branch
from
204ba01 to
ba142d6
Compare
Add permission Add spanner Add Spanner Add changes docker Add packaging Add plugins Add plugins Add Licenses Add changes Add changes Add changes Add changes Add changes Add changes Add changes Add changes Add changes Add changes Add changes in dockerfile Add changes in dockerfile Add changes in dockerfile Add changes in dockerfile Add changes in dockerfile Add changes in dockerfile Add changes in dockerfile did some changes in Dockerfile Add Changes Changes Add changes changes Added Submodule-cdapSpannerMetadata Add Extension Loader Extension-Loader Changes Removed SpannerConfig Version Changes
This reverts commit ba142d6.
This reverts commit 999aefe.
123-komal
force-pushed
the
feature-permission
branch
from
bfea793 to
d3a1fee
Compare
123-komal
force-pushed
the
feature-permission
branch
2 times, most recently
from
c9f8d86 to
26dddf3
Compare
Added SpannerMetadata Submodule and ExtensionLoader Added SpannerMetadata Submodule and ExtensionLoader changes changes
123-komal
force-pushed
the
feature-permission
branch
from
26dddf3 to
a5c6795
Compare
| * using Google Cloud Spanner as the underlying storage. | ||
| * It provides methods for managing metadata within a Spanner database. | ||
| */ | ||
| public class SpannerMetadataStorage implements MetadataStorage { |
There was a problem hiding this comment.
Please follow the ext naming convention - https://github.com/cdapio/cdap/tree/develop/cdap-messaging-ext-spanner
| * A simple class to pass around a Spanner Mutation, along with the metadata | ||
| * change that it effects. | ||
| */ | ||
| public class RequestandChange { |
There was a problem hiding this comment.
See if we can make interface for ES and Cloud spanner and implement it in the ext.
Otherwise check if the class can be renamed (if used in just Cloud Spanner)
| } | ||
|
|
||
| @Override | ||
| public String getName() { |
There was a problem hiding this comment.
can also use - this.getClass().getSimpleName();
| } | ||
|
|
||
| @Override | ||
| public void dropIndex() throws IOException { |
There was a problem hiding this comment.
can return for now - throw new IOException("NOT IMPLEMENTED");
| <groupId>org.hamcrest</groupId> | ||
| <artifactId>hamcrest-core</artifactId> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Please check if this is needed - Usually we add spi dependency only in pom.xml
|
|
||
| //Metadata configs | ||
| public static final String Metadata_Storage_Enabled = "metadata.storage.enabled"; | ||
| public static final String Metadata_Storage_EXT_DIR = "metadata.storage.extensions.dir"; |
There was a problem hiding this comment.
Please check if this property is needed.
| this.extensionLoader = extensionLoader; | ||
| this.extensionLoader.getAll(); | ||
|
|
||
| String providerName = "spanner"; |
There was a problem hiding this comment.
Should not be hardcoded here.
|
|
||
| @Override | ||
| public void close() { | ||
| delegate.close(); |
There was a problem hiding this comment.
usually we use getDelegate() method in all the calls.
|
|
||
| public class DefaultMetadataStorageProviderContext implements MetadataStorageContext { | ||
|
|
||
| public static final String METADATA_STORAGE_PREFIX = "data.storage.properties.gcp-spanner"; |
There was a problem hiding this comment.
There was a problem hiding this comment.
Lets keep this in separate metadata/ package
3 participants
Added a new Submodule cdap-SpannerMetadata