Skip to content

Fix behat failures #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tuanngocnguyen wants to merge 1 commit into
base: MOODLE_39_STABLE
Choose a base branch
from
Open

Fix behat failures #300

tuanngocnguyen wants to merge 1 commit into from

Conversation

@tuanngocnguyen
Copy link
Contributor

@tuanngocnguyen tuanngocnguyen commented Jun 7, 2022 •
edited
Loading

WR #382301

Checking if behat can be enabled

@tuanngocnguyen tuanngocnguyen force-pushed the MOODLE_39_STABLE_enable_behat branch 30 times, most recently from 01bbddd to 22e64a3 Compare June 14, 2022 22:54
@tuanngocnguyen tuanngocnguyen force-pushed the MOODLE_39_STABLE_enable_behat branch 19 times, most recently from 4fb3d4e to 73d1a38 Compare June 15, 2022 13:49
@tuanngocnguyen tuanngocnguyen force-pushed the MOODLE_39_STABLE_enable_behat branch 3 times, most recently from 8ca3cfb to 439cc8a Compare June 28, 2022 22:59
@tuanngocnguyen
Copy link
Contributor Author

tuanngocnguyen commented Jun 28, 2022 •
edited
Loading

Hi @brendanheywood/@Peterburnett ,

I cannot fix/workaround the issue with behat:

Error while stopping WebDriver: Behat\Mink\Exception\DriverException (0) 'Could not close connection'
Attempting to continue with test run. Stacktrace follows:
• line 78 of /vendor/behat/mink/src/Session.php: call to OAndreyev\Mink\Driver\WebDriver->stop()
• line 670 of /lib/tests/behat/behat_hooks.php: call to Behat\Mink\Session->stop()

So I leave it disabled. Instead, I fixed 2 behat failures in this MR

@tuanngocnguyen tuanngocnguyen changed the title DRAFT: Enable behat Fix behat failures Jun 28, 2022
@tuanngocnguyen tuanngocnguyen force-pushed the MOODLE_39_STABLE_enable_behat branch from 439cc8a to 32ded95 Compare June 30, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tuanngocnguyen