Skip to content

Fix json-from-wast where assert_return contains const values #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexcrichton merged 2 commits into from
Feb 4, 2026
Merged

Fix json-from-wast where assert_return contains const values #2435

alexcrichton merged 2 commits into from
Feb 4, 2026
+50 −1

Conversation

@mpoindexter
Copy link
Contributor

@mpoindexter mpoindexter commented Feb 3, 2026

Fixes #2431

@mpoindexter mpoindexter requested a review from a team as a code owner February 3, 2026 23:46
@mpoindexter mpoindexter requested review from alexcrichton and removed request for a team February 3, 2026 23:46
alexcrichton
alexcrichton approved these changes Feb 4, 2026
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Feb 4, 2026
Merged via the queue into bytecodealliance:main with commit eedf8b3 Feb 4, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

json-from-wast fails if the wast file contains an expected result

2 participants

@mpoindexter @alexcrichton