Support for Accessing Authorization Response Parameters#1083
Open
arif-basri wants to merge 1 commit intobshaffer:mainfrom
Open
Support for Accessing Authorization Response Parameters#1083arif-basri wants to merge 1 commit intobshaffer:mainfrom
arif-basri wants to merge 1 commit intobshaffer:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds logic to expose the authorization response parameters (uri_params['query']) in the AuthorizeController. This change enables downstream controller code to access these parameters, which is helpful for implementing the OAuth2 response_mode=form_post specification. With this update, the controller can rewrite response to return HTML with automatic POST action instead of redirect response, by utilizing the parameters directly, improving standards compliance and flexibility for different response modes.
Otherwise we need to parse the redirect url for the parameters which is not elegant.
https://openid.net/specs/oauth-v2-form-post-response-mode-1_0.html