Skip to content
This repository was archived by the owner on May 26, 2022. It is now read-only.

Hyperlink Support#664

Closed
97WaterPolo wants to merge 1 commit intobox:masterfrom
97WaterPolo:add-hyperlink-support
Closed

Hyperlink Support#664
97WaterPolo wants to merge 1 commit intobox:masterfrom
97WaterPolo:add-hyperlink-support

Conversation

@97WaterPolo
Copy link

Adaptation of a previous version PR #352

I found the pull request for a previous version while seeing if native Hyperlink support was added. I personally don't need any other "formulas" just the HYPERLINK to have clickable cells to external websites. Not sure if this will be useful but it is just added the regex and xml from the above PR. First ever PR so not sure if I am doing this right, but a small change if anyone needs hyperlinks like me.

Adaptation of a previous version PR box#352
@boxcla
Copy link

boxcla commented Jun 28, 2019

Hi @97WaterPolo, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

@97WaterPolo
Copy link
Author

Hi @97WaterPolo, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

CLA Signed (if this is a valid PR)

@boxcla
Copy link

boxcla commented Jun 28, 2019

Verified that @97WaterPolo has just signed the CLA. Thanks, and we look forward to your contribution.

@97WaterPolo 97WaterPolo reopened this Jun 28, 2019
@adrilo
Copy link
Collaborator

adrilo commented Jun 29, 2019

Hi @97WaterPolo !
Thanks for submitting your first PR. We try to have the same features for XLSX and ODS files. So I can't accept this PR as is (+ broken/missing tests). Anyway, I'll leave it open so that people can use what you did in their project/fork.

@adrilo adrilo closed this Oct 27, 2019
@GuidoLeibbrand
Copy link

Hi @97WaterPolo !
Thanks for submitting your first PR. We try to have the same features for XLSX and ODS files. So I can't accept this PR as is (+ broken/missing tests). Anyway, I'll leave it open so that people can use what you did in their project/fork.

I think this feature also very good.
Can you describe @adrilo what still needs to be done so that this PR is accepted.
How must the hyperlink syntax look like that it fits?

Another possibility would be not only to set the cell values from outsite
Means other (xlsx, ods) xml elements.

vpoursalidis added a commit to vpoursalidis/spout that referenced this pull request Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants