-
Notifications
You must be signed in to change notification settings - Fork 7
Add initial set support
#36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
set constructsset support
|
Nice, just some tests :) |
|
Done! 🤍 |
|
I'm yet to support
Makes sense to add those two translations to this PR. Checklist:
|
|
Supported Since Tried adding more logic to If we skip it for lines akin to |
|
@bouk Still not sure how to go about this one. Would you prefer dropping support for:
And merge or would u rather give it a try? The rest is ready and with passing tests. Cheers ✌🏻 |
Should be completed now 🎉 Would love ur feedback. |
Fixes #34 #35
Would love some guidance to create the tests.
Note: Currently doesn't support
set -- x y "$@"to append. This is equivalent tofish'sset -a argv x y