Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds Erlang language support to the spell-checking tool by integrating the WhatsApp tree-sitter-erlang parser and including a comprehensive word list from OTP libraries.
Key changes:
- Adds tree-sitter-erlang dependency (version 0.15.0)
- Creates Erlang-specific tree-sitter query file for spell-checking
- Includes a 580-word Erlang-specific dictionary
- Provides example Erlang code and comprehensive tests
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 46 comments.
Show a summary per file
| File | Description |
|---|---|
| word_lists/erlang.txt | New Erlang-specific word list with 580 entries from OTP libraries (contains 38 duplicate entries and minor formatting issues) |
| examples/example.erl | Example Erlang file demonstrating spell-checking capabilities with intentional misspellings |
| crates/codebook/tests/test_erlang.rs | Comprehensive test suite for Erlang spell-checking functionality |
| crates/codebook/src/queries/erlang.scm | Tree-sitter query definitions for capturing Erlang comments, strings, atoms, variables, and function names |
| crates/codebook/src/queries.rs | Registers Erlang language type and settings in the spell-checker |
| crates/codebook/src/dictionaries/combined.gen.txt | Generated combined dictionary file including Erlang words |
| crates/codebook/Cargo.toml | Adds tree-sitter-erlang workspace dependency |
| Cargo.toml | Specifies tree-sitter-erlang version 0.15.0 |
| Cargo.lock | Lock file update with tree-sitter-erlang dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
belltoy
force-pushed
the
feature/erlang
branch
from
f953f68 to
7fff459
Compare
belltoy
force-pushed
the
feature/erlang
branch
from
7fff459 to
b38d266
Compare
belltoy
force-pushed
the
feature/erlang
branch
3 times, most recently
from
fffd51a to
49c2580
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 18 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
belltoy
force-pushed
the
feature/erlang
branch
from
49c2580 to
c3776e0
Compare
belltoy
force-pushed
the
feature/erlang
branch
from
c3776e0 to
a6217f1
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
belltoy
force-pushed
the
feature/erlang
branch
from
4793483 to
8f52b29
Compare
|
Ooof, copilot went off the rails on flagging spelling issues. I've pushed instructions to avoid that in the future. Anyway, thanks for putting this together! Is it ready for review? |
|
Yes. It is ready. |
belltoy
force-pushed
the
feature/erlang
branch
from
8f52b29 to
e296560
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Looks great, thank you! |
|
New version is out! If you're using Zed, we'll need to wait for this PR to merge before Erlang works correctly though: zed-industries/extensions#4551 |
2 participants
Add Erlang support, use WhatsApp erlang tree-sitter. Including word list from OTP libraries.