Open
Conversation
Thejas-bhat
force-pushed
the
merge_from
branch
from
96d5c07 to
881f275
Compare
Thejas-bhat
force-pushed
the
merge_from
branch
from
881f275 to
ab88abf
Compare
Thejas-bhat
changed the title
capemox
requested changes
Feb 23, 2026
| CATCH_AND_HANDLE | ||
| } | ||
|
|
||
| int faiss_Set_coarse_quantizers(FaissIndex* index, FaissIndex* srcIndex) { |
Member
There was a problem hiding this comment.
Can name this specific to SQ, since we will probably look at PQ as well.
| index_ivf->quantizer = faiss::clone_index(reinterpret_cast<const faiss::Index*>(src_index->quantizer)); | ||
| index_ivf->is_trained = true; | ||
|
|
||
| faiss::IndexIVFScalarQuantizer* index_ivsc_src = reinterpret_cast<faiss::IndexIVFScalarQuantizer*>(srcIndex); |
Member
There was a problem hiding this comment.
Since IndexIVFScalarQuantizer inherits from IndexIVF, you can just do the cast to IndexIVFScalarQuantizer and then copy both the quantizer and the sq.
| "can only merge indexes of the same type"); | ||
|
|
||
| // merging only the direct map type array and no map | ||
| bool merge_direct_map_cond = (this->direct_map.type == DirectMap::Array && this->direct_map.type == DirectMap::Array)|| |
Member
There was a problem hiding this comment.
must be
(this->direct_map.type == DirectMap::Array && other->direct_map.type == DirectMap::Array)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.