Fix: Prevent object key normalization in signed URL generation#1548
Open
ryomosao wants to merge 1 commit intobeam-cloud:mainfrom
Open
Fix: Prevent object key normalization in signed URL generation#1548ryomosao wants to merge 1 commit intobeam-cloud:mainfrom
ryomosao wants to merge 1 commit intobeam-cloud:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
pkg/abstractions/volume/multipart.gonormalized object keys usingjoinCleanPath. This behavior could alter the target path, creating signed URLs for unintended files and posing a security risk (information leakage).This change replaces
joinCleanPathwith simple path joining to preserve the raw object key.Summary by cubic
Stopped normalizing object keys when building S3 keys for presigned URLs and multipart uploads. This preserves the exact path provided and prevents signed URLs from pointing to unintended files.
Written for commit a1795ee. Summary will update on new commits.