fix: Allow dependency to be use with Gradle 9#48
fix: Allow dependency to be use with Gradle 9#48validcube wants to merge 1 commit intobdlukaa:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses compatibility with Gradle 9 by updating the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to add support for Gradle 9 by replacing the deprecated jcenter() repository with mavenCentral(). While this change is correct and necessary, it is insufficient on its own. The project's Android Gradle Plugin version is outdated and incompatible with Gradle 9, which will cause build failures. I've left a comment with details on the required additional changes to achieve full Gradle 9 compatibility.
| repositories { | ||
| google() | ||
| jcenter() | ||
| mavenCentral() |
There was a problem hiding this comment.
While replacing jcenter() with mavenCentral() is a necessary step for Gradle 9 compatibility, this change alone is not sufficient. To achieve the goal of this PR, several other dependencies need to be updated:
- Android Gradle Plugin (AGP): The current version
4.1.0(line 12) is not compatible with Gradle 9. You should update it to a more recent version, for example8.3.2, which is compatible with Gradle 8.4+. - Kotlin Version: The AGP update will require a corresponding update to the Kotlin version (
1.7.0on line 5). For AGP 8.3.2, the compatible Kotlin version is1.9.22. - Gradle Wrapper: The project's Gradle wrapper is configured for Gradle
6.7(gradle-wrapper.properties). This must be updated to a version compatible with the new AGP, such as Gradle8.4.
Without these changes, the project will not be buildable with Gradle 9, defeating the purpose of this PR.

This will allow the dependency to be use with Gradle 9
Gradle 9 removed option to use JCenter repository, a better option is to migrate to MavenCentral which
Tested with Gradle 9.3.1 by compiling and running a Android project with this changes on Pixel 7 Android 17 Beta 2