Fix floating window border offset bug in configure_request #1543
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit af3bd8b tried to fix the issue with floating window movement by changing the values passed to window_move_resize, but the actual values of c->floating_rectangle should have also been changed since that structure is expected to hold the coordinates of the outer window including the border.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit af3bd8b tried to fix the issue with floating window movement by changing the values passed to window_move_resize, but the actual values of c->floating_rectangle should have also been changed since that structure is expected to hold the coordinates of the outer window including the border.
Screenshots:
A floating window is spawned and placed in the upper right hand corner:
A new floating window is spawned while the original window is focused. The floating window moves down and to the right by the size of the border.
