Fix memory leaks and performance problems in the source generator #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doesn't do anything useful
ZingBallyhoo
force-pushed
the
incremental
branch
from
7b0b923 to
066d403
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this library, its a great help when working with bitfields. However, the current source generator has major issues and is not functioning incrementally.
ISymbolin incremental pipelines is not allowed.SyntaxNodes in incremental pipelines is not allowed.List<T>in incremental pipelines is not allowed.CompilationProvidercauses the generator to re-run for every keystroke in the IDE.See all the linked discussion from dotnet/roslyn#71629, and the incremental generators cookboook. I have added a test that validates that the generator keeps working incrementally from this point forwards.
The one thing I haven't kept working is the
FieldTypeNotDefined/Cannot infer FieldType/"'{0}.{1}' FieldType cannot be inferred"diagnostic. I am happy to fix it but I couldn't figure out in what situation it's supposed to be reported...