Feature #5242 Make reset button styling configurable in AZ Finder exposed forms#5244
Feature #5242 Make reset button styling configurable in AZ Finder exposed forms#5244
Conversation
Co-authored-by: trackleft <1023167+trackleft@users.noreply.github.com>
Co-authored-by: trackleft <1023167+trackleft@users.noreply.github.com>
Co-authored-by: trackleft <1023167+trackleft@users.noreply.github.com>
Co-authored-by: trackleft <1023167+trackleft@users.noreply.github.com>
Co-authored-by: trackleft <1023167+trackleft@users.noreply.github.com>
…nitization Co-authored-by: trackleft <1023167+trackleft@users.noreply.github.com>
Co-authored-by: trackleft <1023167+trackleft@users.noreply.github.com>
Co-authored-by: trackleft <1023167+trackleft@users.noreply.github.com>
|
@copilot please consider updating the schema file for az_finder for this new setting. |
…r reset_button_classes Co-authored-by: trackleft <1023167+trackleft@users.noreply.github.com>
Done in commit 8dba2f1. I've added:
The post update uses |
…onstant Co-authored-by: trackleft <1023167+trackleft@users.noreply.github.com>
Co-authored-by: trackleft <1023167+trackleft@users.noreply.github.com>
|
@copilot take a look at the pull request checks that ran for this pull request and address any issues |
Co-authored-by: trackleft <1023167+trackleft@users.noreply.github.com>
Fixed in commit 6b9b2bc. The PHPCS check was failing due to two lines exceeding the 80 character limit:
The PHPUnit test failures appear to be unrelated to my changes - they're failing because the scaffolding build cache is missing, causing all tests to fail with "az-quickstart-scaffolding: No such file or directory". This is an infrastructure/cache issue, not a code issue. |
|
@copilot did you see this? |
Co-authored-by: trackleft <1023167+trackleft@users.noreply.github.com>
|
... Yes, fixed in commit 7514b57. The doc comment format violated Drupal coding standards - the short description must be on a single line. I've reformatted it to: /**
* Add default reset_button_classes to existing views.
*
* Updates all views using az_better_exposed_filters.
*/This follows the standard where the first sentence is the short description (line 12), and additional details go in a separate paragraph (line 14). |
|
@zsaenz this PR is not looking for design review, it is more about are you able to change the classes of the buttons and does the database update look correct. |
|
Tugboat has finished building the preview for this pull request! Link: Dashboard: |
|
I tested the database update on a site with a custom finder and it updated correctly for me. |
| is_secondary: false | ||
| reset_button_position: top | ||
| reset_button_counter: true | ||
| reset_button_classes: 'btn btn-sm btn-secondary w-100 mx-1 mb-3' |
There was a problem hiding this comment.
Nitpick: I believe we have a preference for .btn-blue rather than .btn-secondary in Arizona Bootstrap? .btn-secondary isn't included on the Buttons docs page.
| reset_button_classes: 'btn btn-sm btn-secondary w-100 mx-1 mb-3' | |
| reset_button_classes: 'btn btn-sm btn-blue w-100 mx-1 mb-3' |
There was a problem hiding this comment.
I had co-pilot create a new pr for this functionality to be included in the next minor release.#5285
If that gets merged we can update this with the new class.






Make Reset Button Styling Configurable in AZ Finder
Implementation Complete ✅
Changes Made
reset_button_classeswith sanitizationImplementation Details
DEFAULT_RESET_BUTTON_CLASSESHtml::getClass()for sanitizationConfigEntityUpdaterfor batch processingFiles Changed
QuickstartExposedFilters.php- Core functionality with sanitizationaz_finder.schema.yml- Configuration schema definitionaz_finder.post_update.php- Upgrade path for existing sitesSecurity & Quality
Html::getClass()Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.