Skip to content

Conversation

@bobbor
Copy link
Member

@bobbor bobbor commented Nov 11, 2025

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2025

⚠️ No Changeset found

Latest commit: d45aeee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bobbor bobbor force-pushed the feat/bobbor/multi-download branch from c2ef4d9 to 7063657 Compare November 11, 2025 10:36
@bobbor bobbor force-pushed the feat/bobbor/multi-download branch from 7063657 to 3b150ce Compare November 27, 2025 12:26
@bobbor bobbor force-pushed the feat/bobbor/multi-download branch 2 times, most recently from cd71da6 to d043b7b Compare December 8, 2025 14:36
@bobbor bobbor marked this pull request as ready for review December 8, 2025 14:36
@bobbor bobbor requested a review from a team as a code owner December 8, 2025 14:36
@bobbor
Copy link
Member Author

bobbor commented Dec 8, 2025

there is no changeset by design.
the implementation can be used in next (unstable) releases, but should not be part of a version

@bobbor bobbor force-pushed the feat/bobbor/multi-download branch from d043b7b to e45e0de Compare December 9, 2025 09:24
@bobbor bobbor changed the title add POC feat(storage-manager): add multi-file zipdownload Dec 9, 2025
@bobbor bobbor force-pushed the feat/bobbor/multi-download branch from e45e0de to e7b5168 Compare December 9, 2025 10:30
}
});
}
}, 250);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: what's the reason behind 250ms specifically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the issue is, that the handler gets invoked for every file individually.
The handler itself manages a queue of files to download or which are downloading.

Since the download-handler, is only invoked on 4 files at a time, it can happen, that before the next file is being queued by the storage-manager, the download-handler "thinks" the queue is empty and assumes it has processed all files.

this small delay, gives the storage-manager some time push more files into the download-handler, and thus continue downloading.

It would be much more beneficial, if the action-handlers would know how many files are being processed in total e.g. like Array.map, where the signature is <T, R>(item: T, index: number, all: T[]) => R[]

but I'll do a follow-up on this one in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants