Make npm run build and npm run test work with Node 22 (current LTS).#794
Open
nenadvicentic wants to merge 1 commit intoaurelia:masterfrom
Open
Make npm run build and npm run test work with Node 22 (current LTS).#794nenadvicentic wants to merge 1 commit intoaurelia:masterfrom
npm run build and npm run test work with Node 22 (current LTS).#794nenadvicentic wants to merge 1 commit intoaurelia:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys,
I fetched
aurelia-bindingrepository a few days ago, just to realize that neitherbuildnortestcommands work with current LTS version of NodeJS (22.17.1).To fix that, changes I made are minimal.
buildchain is untouched. I only had to change the way Karma bootstraps the tests.build
To fix
npm run buildI have only made an override inpackage.json:test
To fix
npm run test, due to multiple issue withjspm@0, I had to switch to: Webpack v4, Babel v6 andbabel-loader@7. The last version that supportbabel-preset-es2015. I added few more details about it inReadMe.md.I only found out that 3
*.spec.jsfile had missingimport './setup';, but somehow they worked under JSPM loader.Hope you find this patch useful.