Skip to content

Conversation

@DeepanshuMishraa
Copy link
Contributor

Pull Request

The frontend keymaps defined cmd+for terminal toggle, but the Tauri native menu (which is enabled by default on macOS) was registering CmdOrCtrl+J. Since the native menu intercepts keyboard shortcuts at the OS level, pressingCmd+`` wasn't being handled by either system.

Description

  • Changed the Tauri menu to use `CmdOrCtrl+`` to match the frontend
  • Added a fallback in the matcher to use event.code (which returns "Backquote") when event.key is "Dead"

Screenshots/Videos

Before:

Screen.Recording.2026-01-22.at.4.32.45.PM.mov

After:

Screen.Recording.2026-01-22.at.4.46.56.PM.mov

Copilot AI review requested due to automatic review settings January 22, 2026 11:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the terminal toggle keybinding (Cmd+) not working on macOS by addressing a mismatch between the frontend keymap definition and the Tauri native menu registration. The frontend used cmd+``, but the Tauri menu used CmdOrCtrl+J, causing keyboard shortcuts to be mishandled at the OS level.

Changes:

  • Updated Tauri menu registration from CmdOrCtrl+J to `CmdOrCtrl+`` to match frontend keymap
  • Added fallback logic in the keyboard event matcher to handle "Dead" key events by mapping event.code to logical key names

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src-tauri/src/menu.rs Changed terminal toggle keybinding from CmdOrCtrl+J to CmdOrCtrl+` in native menu
src/features/keymaps/utils/matcher.ts Added CODE_TO_KEY mapping and fallback logic to handle Dead key events for special characters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mehmetozguldev mehmetozguldev self-requested a review January 22, 2026 13:23
@mehmetozguldev mehmetozguldev changed the title Fix terminal toggle keybinding (cmd + `) not working on macOs Fix terminal toggle keybinding (cmd + `) not working on MacOS Jan 27, 2026
@mehmetozguldev mehmetozguldev merged commit 9c531c6 into athasdev:master Jan 27, 2026
2 checks passed
@DeepanshuMishraa DeepanshuMishraa deleted the fix/tilda branch January 27, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants