Heroku Release Phase bug#10
Open
sol wants to merge 1 commit intoassertible:masterfrom
sol:heroku-release-bug
Open
Heroku Release Phase bug#10sol wants to merge 1 commit intoassertible:masterfrom sol:heroku-release-bug
sol wants to merge 1 commit intoassertible:masterfrom
sol:heroku-release-bug
Conversation
`release` phase task defined in `Procfile` are run before the app is made available. If a task fails, the new release is not deployed. However, the GitHub deploy status is set to "success" before any releases task are run. This has two consequences: 1. The GitHub deploy status does not accurately reflect the outcome of the release. 2. Assertible will run before the app is deployed. So Assertible will either use a stale release, or fail if there was no previous release. https://devcenter.heroku.com/articles/release-phase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
releasephase task defined inProcfileare run before the app ismade available. If a task fails, the new release is not deployed.
However, the GitHub deploy status is set to "success" before any
releases task are run. This has two consequences:
the release.
either use a stale release, or fail if there was no previous release.
https://devcenter.heroku.com/articles/release-phase