This repository was archived by the owner on Dec 17, 2025. It is now read-only.
Fix: Handle Deleted Namespaces Gracefully During Sync#785
Open
tricktron wants to merge 1 commit intoargoproj:masterfrom
Open
Fix: Handle Deleted Namespaces Gracefully During Sync#785tricktron wants to merge 1 commit intoargoproj:masterfrom
tricktron wants to merge 1 commit intoargoproj:masterfrom
Conversation
tricktron
force-pushed
the
fix-cluster-sync-if-ns-has-been-been-deleted
branch
from
093236d to
57775ce
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #785 +/- ##
==========================================
- Coverage 54.26% 47.63% -6.63%
==========================================
Files 64 64
Lines 6164 6627 +463
==========================================
- Hits 3345 3157 -188
- Misses 2549 3212 +663
+ Partials 270 258 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Implement automatic detection and removal of deleted namespaces to prevent infinite sync failure loops when namespaces are deleted without removing the managed-by label first. Signed-off-by: Thibault Gagnaux <thibault.gagnaux@bit.admin.ch>
tricktron
force-pushed
the
fix-cluster-sync-if-ns-has-been-been-deleted
branch
from
57775ce to
0b5d0a1
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix infinite sync failure loops when managed namespaces are deleted by implementing automatic namespace validation and cleanup during cluster cache synchronization.
Fixes: argoproj/argo-cd#24709
Problem
When namespaces managed by ArgoCD are deleted without first removing the
managed-bylabel, the GitOps Engine enters an infinite failure loop during cluster cache sync operations. TheprocessApi()function attempts to list resources in deleted namespaces, resulting in 403 Forbidden errors from the Kubernetes API. This causes:Root Cause: The
sync()process iterates throughc.namespacesslice containing deleted namespace names but has no validation to check if those namespaces still exist before attempting API operations.Solution
Implement namespace validation with automatic cleanup:
Key Changes
namespaceExists()function - Validates namespace existence using canonicalapierrors.IsNotFound()detectionprocessApi()- Skip deleted namespaces during resource processing using thread-safe trackingsync()- Remove deleted namespaces from configuration after parallel processing completesI also added a test for the scenario called
TestSyncWithDeletedNamespaceand added the default namespace in other tests to not break them.