Skip to content

Fix: reject '@' in HTTP header field names per RFC 9110 #12838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prabhleen0601-stack wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Fix: reject '@' in HTTP header field names per RFC 9110 #12838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/tscore/ParseRules.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ inline CTypeResult
ParseRules::is_token(char c)
{
#ifndef COMPILE_PARSE_RULES
return (parseRulesCType[static_cast<unsigned char>(c)] & is_token_BIT);
return (parseRulesCType[(unsigned char)c] & is_token_BIT);
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed from static_cast<unsigned char> to C-style cast (unsigned char). C++ best practice is to use static_cast for type safety and clarity. This change appears unrelated to the PR's stated purpose of fixing '@' validation.

Suggested change
return (parseRulesCType[(unsigned char)c] & is_token_BIT);
return (parseRulesCType[static_cast<unsigned char>(c)] & is_token_BIT);

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@bryancall bryancall Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no C casts, please

#else
return (is_char(c) && !(is_ctl(c) || is_tspecials(c)));
#endif
Expand Down Expand Up @@ -712,7 +712,7 @@ ParseRules::is_http_field_name(char c)
#ifndef COMPILE_PARSE_RULES
return (parseRulesCType[static_cast<unsigned char>(c)] & is_http_field_name_BIT);
#else
if (!is_char(c) || is_control(c) || (is_mime_sep(c) && c != '@') || c == '=' || c == ':') {
if (!is_char(c) || is_control(c) || is_mime_sep(c) || c == '=' || c == ':') {
return false;
}
return true;
Expand Down