-
Notifications
You must be signed in to change notification settings - Fork 51
HDDS-14295. [Website v2] [Docs] [Administrator Guide] Ozone command line tools #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: HDDS-9225-website-v2
Are you sure you want to change the base?
Conversation
sarvekshayr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Russole for working on this.
Please include Ozone admin commands as well.
Let's change the structure a bit here -
Administrator Guide -> Operations -> Tools (Main page)
Sub pages:
- Ozone Admin
- Ozone Debug
- Ozone Repair
When we create Debug section, we can move LDB tool under it. (This can be done later)
echonesis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Russole , left some comments.
| - FSO-tree | ||
|
|
||
| - snapshot | ||
|
|
||
| - update-transaction | ||
|
|
||
| - quota | ||
|
|
||
| - compact | ||
|
|
||
| - skip-ratis-transaction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could remove the new lines.
| **Note:** All repair commands support a `--dry-run` option which allows a user to see what repair the command will be performing without actually making any changes to the cluster. | ||
| Use the `--force` flag to override the running service check in false-positive cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use Admonitions.
:::note|
@Russole could you take a look at @echonesis 's comments above? |
|
Sure, I’ll update the changes based on the comments. |
|
Thanks @sarvekshayr and @echonesis for the review. Updates have been made based on the comments. |
sarvekshayr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including all 3 sections in one PR.
| ## Snapshots | ||
|
|
||
| This section documents how to manage and configure Ozone snapshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not relevant here. Please remove it.
| > Multiple filtering options can be used together in a single command. | ||
| ### –startkey and –endkey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use double dash before these options. Applies to --fields and --filter as well.
| ### –startkey and –endkey | |
| ### --startkey and --endkey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @sarvekshayr
--startkey and --endkey imply command usage.
| @@ -0,0 +1,227 @@ | |||
| # LDB Tool | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have an LDB page - https://ozone-site-v2.staged.apache.org/docs/administrator-guide/operations/ldb
Please move it here instead.
echonesis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Russole for the patch, left some comments.
| By default, the contents are printed on the console, but it can be redirected to a file using the `--out` option. <br /> | ||
| `--length` can be used to limit the number of records being printed. <br /> | ||
| `--count` doesn’t print the records, it shows the approximate number of records. This is not accurate. <br /> | ||
| `ozone debug ldb scan` command provides many filtering options to make debugging easier, elaborated below: <br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<br /> is better for HTML.
In Markdown, we could use new line instead.
| > Multiple filtering options can be used together in a single command. | ||
| ### –startkey and –endkey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @sarvekshayr
--startkey and --endkey imply command usage.
What changes were proposed in this pull request?
Migrate the Ozone tools page https://ozone.apache.org/docs/edge/tools/index.html specifically Ozone Repair and Ozone Admin to the v2 page under Administrator Guide -> Operations https://ozone-site-v2.staged.apache.org/docs/administrator-guide/operations/
What is the link to the Apache Jira?
https://issues.apache.org/jira/browse/HDDS-14295
How was this patch tested?