pic32_eth/shell: Fix command call#3588
Merged
kasjer merged 1 commit intoapache:masterfrom Mar 17, 2026
Merged
Conversation
There was mismatch between pic32_eth_cmd and function pic32_eth_compat_cmd. Function was ext (with streamer) while description did not have sc_ext set. Additionally all commands in pic32_eth_commands were EXT while call to them from pic32_eth_compat_cmd was using wrong type resulting in wrong argument usage. eth stats eth phy ... did not work as expected functionality was still available via module /eth stats /etc phy worked fine This fixes mismatch described above. Signed-off-by: Jerzy Kasenberg <jerzy@apache.org>
kasjer
force-pushed
the
kasjer/pic32_eth_shell-fix
branch
from
4137d36 to
2528d95
Compare
sjanc
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was mismatch between pic32_eth_cmd
and function pic32_eth_compat_cmd.
Function was ext (with streamer) while
description did not have sc_ext set.
Additionally all commands in pic32_eth_commands
were EXT while call to them from
pic32_eth_compat_cmd was using wrong type
resulting in wrong argument usage.
eth stats
eth phy
...
did not work as expected
functionality was still available via module
/eth stats
/etc phy
worked fine
This fixes mismatch described above.