fix(server): handle entity ID gaps on bootstrap after deletions #2548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubcio
changed the title
hubcio
force-pushed
the
sparse-index
branch
2 times, most recently
from
9fdc6e9 to
074cd40
Compare
Server panicked on restart when streams, topics, partitions, or consumer
groups had been deleted, creating gaps in ID sequences.
The issue: `slab.insert()` auto-assigns sequential IDs (0, 1, 2...),
but after deletions the state file contains non-sequential IDs (e.g.,
{0, 2} after deleting ID 1). On restart, bootstrap called `insert()`
which returned sequential IDs, causing assertion failures when the
assigned ID didn't match the expected ID from state.
The fix uses `Slab::from_iter()` via new `from_entries()` constructors
on Streams, Topics, Partitions, and ConsumerGroups. This correctly
places entities at their original keys regardless of gaps.
Changes:
- Add `from_entries()` to Streams, Topics, Partitions, ConsumerGroups
- Add `set_topics()`, `set_partitions()`, `set_consumer_groups()` setters
- Refactor `load_streams()` to bottom-up construction using `from_entries()`
- Remove ID mismatch assertions (no longer needed)
numinnex
approved these changes
Jan 8, 2026
spetz
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server panicked on restart when streams, topics, partitions, or consumer
groups had been deleted, creating gaps in ID sequences.
The issue:
slab.insert()auto-assigns sequential IDs (0, 1, 2...),but after deletions the state file contains non-sequential IDs (e.g.,
{0, 2} after deleting ID 1). On restart, bootstrap called
insert()which returned sequential IDs, causing assertion failures when the
assigned ID didn't match the expected ID from state.
The fix uses
Slab::from_iter()via newfrom_entries()constructorson Streams, Topics, Partitions, and ConsumerGroups. This correctly
places entities at their original keys regardless of gaps.