Skip to content

Conversation

@slbotbm
Copy link
Contributor

@slbotbm slbotbm commented Dec 26, 2025

closes #2455

@slbotbm
Copy link
Contributor Author

slbotbm commented Dec 26, 2025

Since HeaderValue has String value in its signature, the current implementation converts all the values to string, ignoring the HeaderKind, which can indicate a non-string value.

Copy link
Member

@mmodzelewski mmodzelewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @slbotbm. I left some minor comments. Otherwise, the PR looks great.

@slbotbm
Copy link
Contributor Author

slbotbm commented Jan 2, 2026

@mmodzelewski thank you for the review! I have addressed all of your comments. After removing the optional mapping from userHeaders, some http integration tests were failing due to jackson desrializing empty userHeaders as null. To address this, I added the annotation @JsonSetter(nulls = Nulls.AS_EMPTY) so that Jackson would return an empty map.

@mmodzelewski
Copy link
Member

@slbotbm thanks, added a few comments regarding the new code.

@mmodzelewski
Copy link
Member

@slbotbm all looks great, thanks again for the contribution! :)

@spetz spetz merged commit b5c9640 into apache:master Jan 2, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Java SDK] Implement userHeader serialization/deserialization for sync/async clients

3 participants