GUACAMOLE-2045: Add ability to force prompting for missing credentials#580
Draft
pv2b wants to merge 1 commit intoapache:mainfrom
Draft
GUACAMOLE-2045: Add ability to force prompting for missing credentials#580pv2b wants to merge 1 commit intoapache:mainfrom
pv2b wants to merge 1 commit intoapache:mainfrom
Conversation
Author
|
So I wrote this code with the justification provided in GUACAMOLE-2045. However, when testing it, I discovered that this is probably entirely unneccessary, because there seems to be some change in behaviour where FreeRDP 3 already does this by itself. Because of that, I had to test this code against FreeRDP 2. I'm putting the code out there because I already wrote it, but I think I need to figure out what's changed in FreeRDP to change this behaviour first, to see if this is even an idea that makes any sense. There may be a different undesired behavioural change here, where it's not longer possible to get the graphical credential screen on a non-NLA server. I'm not entirely sure what's going on here yet, something doesn't make sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.