[VL] Close ColumnarBatch in ColumnarCollectLimitExec for skipped and sliced batches#11754
Open
acvictor wants to merge 1 commit intoapache:mainfrom
Open
[VL] Close ColumnarBatch in ColumnarCollectLimitExec for skipped and sliced batches#11754acvictor wants to merge 1 commit intoapache:mainfrom
acvictor wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
@ArnavBalyan can you please review this fix? Thanks! |
| batch | ||
| } else { | ||
| VeloxColumnarBatches.slice(batch, startIndex, needed) | ||
| val sliced = VeloxColumnarBatches.slice(batch, startIndex, needed) |
Contributor
There was a problem hiding this comment.
The sliced calls velox slice API, reuse buffers of batch, so we cannot close it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR closes
ColumnarBatchfor skipped or sliced batches inColumnarCollectLimitExec.ColumnarCollectLimitExec.fetchNextBatch()leaks memory in two cases:In both cases the
ColumnarBatchobject is small but it holds a JNI handle to a native Velox vector. Since ColumnarBatch has no finalizer, the native memory is only freed by an explicit close() call. Queries with large offsets (e.g., OFFSET 10000) would leak one batch per skipped chunk.How was this patch tested?
Existing UTs
Was this patch authored or co-authored using generative AI tooling?
No