[GLUTEN-1433] [VL] Add config to disable TimestampNTZ validation fallback#11720
Open
Mariamalmesfer wants to merge 1 commit intoapache:mainfrom
Open
[GLUTEN-1433] [VL] Add config to disable TimestampNTZ validation fallback#11720Mariamalmesfer wants to merge 1 commit intoapache:mainfrom
Mariamalmesfer wants to merge 1 commit intoapache:mainfrom
Conversation
Mariamalmesfer
force-pushed
the
validate-localtimestamp
branch
3 times, most recently
from
ae23e8b to
15b228c
Compare
Mariamalmesfer
force-pushed
the
validate-localtimestamp
branch
5 times, most recently
from
14ab5a6 to
0b12c90
Compare
Mariamalmesfer
changed the title
Mariamalmesfer
changed the title
Mariamalmesfer
force-pushed
the
validate-localtimestamp
branch
from
0b12c90 to
e91e760
Compare
zhouyuan
reviewed
Mar 10, 2026
| case BooleanType | ByteType | ShortType | IntegerType | LongType | FloatType | DoubleType | | ||
| StringType | BinaryType | _: DecimalType | DateType | TimestampType | | ||
| YearMonthIntervalType.DEFAULT | NullType => | ||
| true |
Member
There was a problem hiding this comment.
We should also check this flag in the validator code here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a config to control fallback validation for TimestampNTZType in the Velox backend and adds a test for localtimestamp().
Currently, the validator treats TimestampNTZType as unsupported and forces the query to fall back to Spark. This makes it hard to develop and test features related to TimestampNTZ, including functions like localtimestamp().
With this change, the validation rule can be temporarily disabled during development and testing.
Related issue: #1433