Skip to content

[VL] Test rebase #11712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhouyuan wants to merge 4 commits into
base: main
Choose a base branch
from
+4 −6
Open

[VL] Test rebase #11712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7bd85b5
[VL] Test rebase
zhouyuan Mar 6, 2026
d77e74e
fix
zhouyuan Mar 6, 2026
d183bd0
fix
zhouyuan Mar 6, 2026
250c375
fix
zhouyuan Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/velox/compute/VeloxBackend.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ void VeloxBackend::init(
// serde, for spill
facebook::velox::serializer::presto::PrestoVectorSerde::registerVectorSerde();
}
if (!isRegisteredNamedVectorSerde(facebook::velox::VectorSerde::Kind::kPresto)) {
if (!isRegisteredNamedVectorSerde("Presto")) {
// RSS shuffle serde.
facebook::velox::serializer::presto::PrestoVectorSerde::registerNamedVectorSerde();
}
Expand Down
2 changes: 1 addition & 1 deletion cpp/velox/shuffle/VeloxShuffleReader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,7 +732,7 @@ VeloxRssSortShuffleReaderDeserializer::VeloxRssSortShuffleReaderDeserializer(
rowType_(rowType),
batchSize_(batchSize),
veloxCompressionType_(veloxCompressionType),
serde_(getNamedVectorSerde(facebook::velox::VectorSerde::Kind::kPresto)),
serde_(getNamedVectorSerde("presto")),
deserializeTime_(deserializeTime) {
serdeOptions_ = {false, veloxCompressionType_};
}
Expand Down
4 changes: 1 addition & 3 deletions cpp/velox/substrait/SubstraitToVeloxPlan.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1447,8 +1447,6 @@ core::PlanNodePtr SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
SubstraitParser::parseColumnTypes(baseSchema, columnTypes);
}

// Velox requires Filter Pushdown must being enabled.
bool filterPushdownEnabled = true;
auto names = colNameList;
auto types = veloxTypeList;

Expand All @@ -1468,7 +1466,7 @@ core::PlanNodePtr SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
}
common::SubfieldFilters subfieldFilters;
tableHandle = std::make_shared<connector::hive::HiveTableHandle>(
connectorId, "hive_table", filterPushdownEnabled, std::move(subfieldFilters), remainingFilter, tableSchema);
connectorId, "hive_table", std::move(subfieldFilters), remainingFilter, tableSchema);

// Get assignments and out names.
std::vector<std::string> outNames;
Expand Down
2 changes: 1 addition & 1 deletion ep/build-velox/src/get-velox.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ set -exu

CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd)
VELOX_REPO=https://github.com/IBM/velox.git
VELOX_BRANCH=dft-2026_03_03-iceberg
VELOX_BRANCH=dft-2026_03_06-iceberg
VELOX_ENHANCED_BRANCH=ibm-2026_03_03
VELOX_HOME=""
RUN_SETUP_SCRIPT=ON
Expand Down
Loading