[VL] Trigger GPU docker build if script changes#11695
Draft
zhouyuan wants to merge 8 commits intoapache:mainfrom
Draft
[VL] Trigger GPU docker build if script changes#11695zhouyuan wants to merge 8 commits intoapache:mainfrom
zhouyuan wants to merge 8 commits intoapache:mainfrom
Conversation
Signed-off-by: Yuan <yuanzhou@apache.org>
zhouyuan
changed the title
| push: | ||
| pull_request: | ||
| paths: | ||
| - 'docs/**' |
Contributor
There was a problem hiding this comment.
Do we need to add get-velox.sh?
| run: | | ||
| git clone --depth 10 --branch main https://github.com/facebookincubator/velox.git velox | ||
| cd velox | ||
| if [[ $(git diff --name-only ${{ github.event.before }} ${{ github.event.after }} | grep -E '(^|/)scripts/.*') ]]; then |
Contributor
There was a problem hiding this comment.
If cudf dependency version changed, we need to build the docker image, the source adapter image does not include cudf, I install it in gluten cudf image.
Member
Author
There was a problem hiding this comment.
would you please make a change on meta/velox?
Contributor
There was a problem hiding this comment.
Do you mean install cudf in set up script?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
To update the gpu docker image if velox adapter changes
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?