Skip to content

[Opt](cloud) cache table version for cloud mode #59339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 2 commits into from
Dec 29, 2025
Merged

[Opt](cloud) cache table version for cloud mode #59339

gavinchou merged 2 commits into from
Dec 29, 2025

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Dec 24, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Dec 24, 2025

run buildall

gavinchou
gavinchou previously approved these changes Dec 24, 2025
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
}
}

public boolean isCachedTableVersionExpired() {
Copy link
Contributor

@gavinchou gavinchou Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we check if (Config.isNotCloudMode()) return true; ?
cache is only applicable in cloud mode.
or we add some comment here ?

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

PR approved by anyone and no changes requested.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Dec 24, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 24, 2025
@doris-robot
Copy link

doris-robot commented Dec 24, 2025

TPC-H: Total hot run time: 35014 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5717abdc927973a5e2a71ceef9d853d6fbbf9dbe, data reload: false

------ Round 1 ----------------------------------
q1	17634	4266	4073	4073
q2	2019	346	229	229
q3	10184	1318	725	725
q4	10219	890	327	327
q5	7538	2096	1959	1959
q6	186	169	141	141
q7	980	857	702	702
q8	9359	1474	1136	1136
q9	6975	5387	5293	5293
q10	6823	2391	1990	1990
q11	522	330	300	300
q12	625	726	589	589
q13	17777	3697	2979	2979
q14	293	286	273	273
q15	588	513	511	511
q16	697	687	627	627
q17	696	777	535	535
q18	7468	7022	7015	7015
q19	1087	946	604	604
q20	384	350	241	241
q21	4189	3897	3788	3788
q22	1077	1023	977	977
Total cold run time: 107320 ms
Total hot run time: 35014 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4129	4055	4087	4055
q2	336	418	318	318
q3	2148	2632	2280	2280
q4	1313	1792	1292	1292
q5	4230	4503	4423	4423
q6	235	178	137	137
q7	2210	1957	1773	1773
q8	2992	2575	2509	2509
q9	7577	7486	7350	7350
q10	3122	3282	2824	2824
q11	618	539	519	519
q12	653	860	611	611
q13	3655	3962	3372	3372
q14	285	302	268	268
q15	534	520	573	520
q16	759	696	617	617
q17	1181	1463	1446	1446
q18	7759	7753	7654	7654
q19	843	853	882	853
q20	2056	2137	1849	1849
q21	4841	4194	4219	4194
q22	1078	1029	973	973
Total cold run time: 52554 ms
Total hot run time: 49837 ms

@doris-robot
Copy link

doris-robot commented Dec 24, 2025

TPC-DS: Total hot run time: 179426 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5717abdc927973a5e2a71ceef9d853d6fbbf9dbe, data reload: false

query5	4413	588	444	444
query6	341	225	207	207
query7	4215	453	269	269
query8	314	250	241	241
query9	8727	2521	2521	2521
query10	457	356	312	312
query11	15447	15066	14722	14722
query12	176	116	118	116
query13	1254	495	376	376
query14	6085	2976	2728	2728
query14_1	2667	2673	2631	2631
query15	212	201	187	187
query16	890	470	470	470
query17	1148	706	599	599
query18	2432	441	384	384
query19	230	225	196	196
query20	119	124	112	112
query21	219	139	114	114
query22	4083	4007	3946	3946
query23	16617	16285	16083	16083
query23_1	16013	16161	16005	16005
query24	7368	1632	1249	1249
query24_1	1230	1226	1209	1209
query25	556	478	416	416
query26	1243	262	159	159
query27	2790	466	304	304
query28	4460	2112	2105	2105
query29	781	528	437	437
query30	312	249	209	209
query31	817	686	646	646
query32	78	69	96	69
query33	537	326	290	290
query34	901	884	551	551
query35	752	831	706	706
query36	870	930	823	823
query37	133	99	78	78
query38	2923	3010	2961	2961
query39	759	758	728	728
query39_1	714	703	722	703
query40	221	131	120	120
query41	67	62	62	62
query42	110	108	109	108
query43	437	426	396	396
query44	1309	739	733	733
query45	189	189	181	181
query46	878	981	605	605
query47	1670	1724	1654	1654
query48	312	328	238	238
query49	639	428	358	358
query50	659	298	224	224
query51	3839	3818	3815	3815
query52	103	112	99	99
query53	330	354	298	298
query54	282	261	245	245
query55	88	78	69	69
query56	294	303	307	303
query57	1136	1128	1094	1094
query58	279	251	260	251
query59	2394	2514	2452	2452
query60	319	317	290	290
query61	162	162	150	150
query62	752	731	691	691
query63	339	305	303	303
query64	4930	1352	1136	1136
query65	4001	3948	3976	3948
query66	1484	445	331	331
query67	15139	15082	14901	14901
query68	3339	1056	751	751
query69	492	363	320	320
query70	1031	951	979	951
query71	357	315	291	291
query72	6434	4940	5110	4940
query73	675	627	309	309
query74	8924	8979	8685	8685
query75	3174	3159	2803	2803
query76	3805	1153	746	746
query77	542	381	291	291
query78	9501	9582	8901	8901
query79	1047	885	615	615
query80	1167	657	552	552
query81	559	271	238	238
query82	411	135	104	104
query83	396	264	246	246
query84	260	112	104	104
query85	934	503	473	473
query86	384	305	279	279
query87	3140	3185	3169	3169
query88	3277	2309	2285	2285
query89	465	419	389	389
query90	1995	162	159	159
query91	172	166	140	140
query92	70	63	60	60
query93	1052	918	566	566
query94	523	301	275	275
query95	581	379	305	305
query96	591	473	213	213
query97	2280	2318	2191	2191
query98	213	196	192	192
query99	1300	1354	1304	1304
Total cold run time: 254790 ms
Total hot run time: 179426 ms

@doris-robot
Copy link

doris-robot commented Dec 24, 2025

ClickBench: Total hot run time: 26.99 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5717abdc927973a5e2a71ceef9d853d6fbbf9dbe, data reload: false

query1	0.05	0.04	0.06
query2	0.10	0.06	0.05
query3	0.25	0.08	0.08
query4	1.61	0.12	0.10
query5	0.27	0.26	0.25
query6	1.18	0.63	0.63
query7	0.03	0.02	0.02
query8	0.06	0.04	0.05
query9	0.57	0.50	0.48
query10	0.56	0.55	0.55
query11	0.16	0.10	0.10
query12	0.14	0.12	0.12
query13	0.62	0.60	0.60
query14	0.98	0.98	0.96
query15	0.82	0.79	0.80
query16	0.41	0.38	0.40
query17	1.02	1.02	1.00
query18	0.24	0.21	0.22
query19	1.85	1.80	1.85
query20	0.02	0.01	0.01
query21	15.45	0.25	0.13
query22	5.01	0.05	0.05
query23	16.12	0.29	0.10
query24	1.12	0.23	0.19
query25	0.09	0.10	0.09
query26	0.14	0.14	0.14
query27	0.06	0.05	0.04
query28	3.76	1.22	1.02
query29	12.66	4.07	3.26
query30	0.27	0.13	0.14
query31	2.81	0.61	0.40
query32	3.23	0.53	0.45
query33	3.02	3.04	3.01
query34	17.10	5.18	4.48
query35	4.55	4.46	4.50
query36	0.65	0.50	0.48
query37	0.10	0.06	0.06
query38	0.07	0.05	0.03
query39	0.04	0.03	0.03
query40	0.18	0.15	0.14
query41	0.09	0.03	0.03
query42	0.05	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 97.55 s
Total hot run time: 26.99 s

@wm1581066 wm1581066 requested a review from morrySnow December 24, 2025 13:35
@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 24, 2025

FE Regression Coverage Report

Increment line coverage 75.00% (15/20) 🎉
Increment coverage report
Complete coverage report

dataroaring
dataroaring approved these changes Dec 26, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2025

PR approved by at least one committer and no changes requested.

@gavinchou gavinchou self-requested a review December 29, 2025 07:05
@gavinchou gavinchou merged commit aa2eb58 into apache:master Dec 29, 2025
31 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 29, 2025
@bobhan1
[Opt](cloud) cache table version for cloud mode (#59339)
861b380
@github-actions github-actions bot mentioned this pull request Dec 29, 2025
Open
bobhan1 added a commit to bobhan1/doris that referenced this pull request Dec 29, 2025
@bobhan1
[Opt](cloud) cache table version for cloud mode (apache#59339)
aa2324d
@bobhan1 bobhan1 mentioned this pull request Dec 29, 2025
Open
bobhan1 added a commit to bobhan1/doris that referenced this pull request Dec 29, 2025
@bobhan1
[Opt](cloud) cache table version for cloud mode (apache#59339)
312ee81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

@morrySnow morrySnow Awaiting requested review from morrySnow

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x dev/3.1.x-conflict dev/4.0.x reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bobhan1 @Thearas @doris-robot @hello-stephen @gavinchou @dataroaring