Open
Conversation
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Member
Author
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
ZENOTME
reviewed
Feb 4, 2026
| /// Computes and checks the 16-bit seed hash from the given long seed. | ||
| /// | ||
| /// The seed hash may not be zero in order to maintain compatibility with older serialized | ||
| /// versions that did not have this concept. |
Contributor
There was a problem hiding this comment.
Does this mean that we should check the return value to prevent 0?
Member
Author
There was a problem hiding this comment.
I suppose so.
cc @leerho I can't see similar requiremeny based on barely the Rust code. Could you provide more context why 0 is not allowed here?
Member
Author
There was a problem hiding this comment.
BTW this comment is copied from computeSeedHash's Java version.
Signed-off-by: tison <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #37