[Variant] Support ['fieldName'] in VariantPath parser
#9276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klion26
force-pushed
the
variant-path-field-in-bracket
branch
from
88e1964 to
3201b0e
Compare
alamb
reviewed
Jan 27, 2026
|
|
||
| /// Parses a path string, panics on invalid input. | ||
| /// Only use for tests for known-valid input. | ||
| pub fn from_str_unchecked(s: &'a str) -> Self { |
Contributor
There was a problem hiding this comment.
In rust and other parts of this crate the "unchecked" word is often used to denote unsafe code -- specifically that could lead to undefined behavior
I suggest we don't call it "unchecked"
I think just from_str is probably fine ?
| } | ||
|
|
||
| /// Create from &str with support for dot notation | ||
| impl<'a> From<&'a str> for VariantPath<'a> { |
Contributor
There was a problem hiding this comment.
This is a breaking API (which is fine, I think, we should just make sure we have the API right this time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
..and['fieldName']syntax in the VariantPath parser #9050.Rationale for this change
What changes are included in this PR?
Add
[fieldName]support inVariantPathparser, will throw an error if the parser fails.Also support escaping
\inside brackets. If we force users to use brackets when the field contains special characters, maybe we can also close #8954Sample behaviors(read more on the code doc)
[foo]-> filedfoo[2]-> index 2[a.b]-> fielda.b[a\]b]-> fielda]b[a\xb]-> fieldaxbAre these changes tested?
Added tests
Are there any user-facing changes?
Yes, there are some user-facing changes, but
parquet-variantis still experient for now, so maybe we don't need to wait for a major version.