fix(file): resolve 1ms timestamp race in sequential file edits #6744
+37
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequential file edits fail with "File modified since it was last read" showing 1-10ms timestamp differences, even with no external modifications.
Root cause:
FileTime.read()storesnew Date()instead of the file's actual mtime. After writes, filesystem mtime updates can lag slightly (especially Windows NTFS, WSL2), causing false positives inassert().Fix:
FileTime.read()now accepts optionalmtimeparameterassert()for edge cases