Skip to content

Ability to pass a FactoryInstance to WaveformAudioBufferSink which will create custom WaveformBar instances#2998

Closed
SathyaTadepalli wants to merge 1 commit intoandroidx:mainfrom
adobe:user/tadepall/waveform-bar-factory
Closed

Ability to pass a FactoryInstance to WaveformAudioBufferSink which will create custom WaveformBar instances#2998
SathyaTadepalli wants to merge 1 commit intoandroidx:mainfrom
adobe:user/tadepall/waveform-bar-factory

Conversation

@SathyaTadepalli
Copy link

@SathyaTadepalli SathyaTadepalli commented Jan 9, 2026

If a consumer app wants to override the behavior of WaveformBar it is not possible, because the creation is happening internally in WaveformAudioBufferSink.
One option is to have a override constructor for WaveformAudioBufferSink, which takes an Factory that will be responsible for creating WaveformBar.
Consumer app can pass this factory instance and create custom WaveformBar instances.
The current constructor which is present will be still available and the current WaveformBar will be created.
There will be no impact in current behavior

Added unit test for the custom factory.

@google-cla
Copy link

google-cla bot commented Jan 9, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@microkatz
Copy link
Contributor

@SathyaTadepalli

If you could please sign the CLA agreement first then that would be great! Thanks!

@icbaker
Copy link
Collaborator

icbaker commented Jan 26, 2026

Closing because the CLA hasn't been signed in 3 weeks. Please re-open or file a new PR if you are able to sign the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants