Remove @Nullable from MediaButtonReceiver.onReceive()#2926
Open
kelmer44 wants to merge 2 commits intoandroidx:mainfrom
Open
Remove @Nullable from MediaButtonReceiver.onReceive()#2926kelmer44 wants to merge 2 commits intoandroidx:mainfrom
kelmer44 wants to merge 2 commits intoandroidx:mainfrom
Conversation
Author
|
I think i confused CI by pointing to the wrong branch 👀 |
| */ | ||
| @Override | ||
| public void onReceive(Context context, @Nullable Intent intent) { | ||
| public void onReceive(Context context, Intent intent) { |
Contributor
There was a problem hiding this comment.
As far as I can tell, if there is no @nullable or @NotNull annotation on Android framework code, then there is no nullability information available and we can't assume this is non-null.
Agreed the doc is clear about it and we can't do something sensible without an Intent. Mind adding checkNotNull(intent) when passing it further down. Sorry for being overly picky, I see we would have a NPE right after but I think I'd prefer this being consistently where we get the garbage input. Shouldn't hurt as we agree this doesn't happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs for
onReceivestate:So I am proposing to remove this qualifier. I wonder if it's possible to get this method called with a null parameter, other than clients calling this method directly, in which case I think enforcing a non-nullable parameter is all the better.
This prevents all extending kotlin classes from having to nullsafe the intent parameter before continuing.