work-in-progress-do not review - add pbl snippets #758

kumann-dev · 2026-01-05T10:18:05Z

No description provided.

snippet-bot · 2026-01-05T10:18:11Z

Here is the summary of changes.

You are about to add 10 region tags.

playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:61, tag android_playbilling_initialize_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:80, tag android_playbilling_enableautoreconnect_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:92, tag android_playbilling_startconnection_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:115, tag android_playbilling_queryproductdetails_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:143, tag android_playbilling_consumeproduct_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:159, tag android_playbilling_acknowledge_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:175, tag android_playbilling_getbillingconfig_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:196, tag android_playbilling_subscription_replace_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:222, tag android_playbilling_subscription_update_deprecated_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:252, tag android_playbilling_inappmessaging_java

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

gemini-code-assist · 2026-01-05T10:18:31Z

Summary of Changes

Hello @kumann-dev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new Android module dedicated to showcasing Google Play Billing Library functionalities. It establishes the necessary build configurations and dependencies, and provides a robust wrapper class that encapsulates a wide range of billing operations, from initializing the billing client to managing subscriptions and in-app messages. This module serves as a set of practical examples for integrating in-app purchases and subscriptions.

Highlights

New Play Billing Library Module: A new Android module named playbillinglibrary has been added to the project, intended to house code snippets and examples for Google Play Billing.
Google Play Billing Library Integration: The project now includes the Google Play Billing Library version 8.3.0 as a dependency, along with an AndroidX Compose runtime library.
Comprehensive BillingClientWrapper: A BillingClientWrapper.java class has been introduced, providing a structured approach to various billing operations, including connection management, product detail queries, purchase handling (consume/acknowledge), subscription updates, and in-app messaging.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new playbillinglibrary module with code snippets for integrating Google Play Billing. While the PR title indicates it's a work-in-progress, there are several critical issues that should be addressed. The module is incorrectly configured as an Android application instead of a library. The BillingClientWrapper class has potential memory leaks due to incorrect handling of Activity and Context references, uses hardcoded values for product IDs and purchase tokens, and has incomplete error handling. These issues affect the correctness, security, and reusability of the billing library.

gemini-code-assist · 2026-01-05T10:21:45Z

playbilling/build.gradle

@@ -0,0 +1,44 @@
+plugins {
+    alias(libs.plugins.android.application)


The module is named playbillinglibrary, which implies it should be a library. However, it's configured as an application using the com.android.application plugin. For a reusable library, you should use the com.android.library plugin instead.

alias(libs.plugins.android.library)

gemini-code-assist · 2026-01-05T10:21:45Z

playbilling/build.gradle

+    }
+
+    defaultConfig {
+        applicationId "com.example.pbl"


An applicationId is only required for application modules that can be installed on a device. Since this module should be a library, this line should be removed.

gemini-code-assist · 2026-01-05T10:21:45Z

playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java

+    private final Context context;
+    private final Activity activity;
+    private final BillingClient billingClient;
+
+    private List<ProductDetails> productDetailsList;
+    private ProductDetails productDetails;
+
+    public BillingClientWrapper(Context context, Activity activity) {
+        this.context = context;
+        this.activity = activity;


Storing a direct reference to an Activity or its Context in a long-lived object like this wrapper is a common source of memory leaks in Android. The Activity can't be garbage collected if the wrapper outlives it.

A safer pattern is to:

Store the applicationContext to avoid leaking the Activity.

Remove the activity field entirely.

Pass the Activity as a parameter to the methods that require it, such as launchBillingFlow and showInAppMessages.

Suggested change

private final Context context;

private final Activity activity;

private final BillingClient billingClient;

private List<ProductDetails> productDetailsList;

private ProductDetails productDetails;

public BillingClientWrapper(Context context, Activity activity) {

this.context = context;

this.activity = activity;

private final Context context;

private final BillingClient billingClient;

private List<ProductDetails> productDetailsList;

private ProductDetails productDetails;

public BillingClientWrapper(Context context) {

this.context = context.getApplicationContext();

gemini-code-assist · 2026-01-05T10:21:45Z

playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java

+                        .setProductList(
+                                ImmutableList.of(
+                                        QueryProductDetailsParams.Product.newBuilder()
+                                                .setProductId("product_id_example")


Hardcoding product IDs like "product_id_example" makes the code inflexible and error-prone. This value should be passed as a parameter to the queryProductDetails method or loaded from a configuration file to make the wrapper reusable and easier to maintain.

gemini-code-assist · 2026-01-05T10:21:46Z

playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java

+            // You could initiate a query here or show an error message.
+            return;
+        }
+        String purchaseTokenOfExistingSubscription = "purchase_token";


A purchase token is hardcoded. This is a placeholder that will cause the feature to fail in a real application. This value must be obtained dynamically from a Purchase object for an existing subscription.

gemini-code-assist · 2026-01-05T10:21:46Z

playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java

+        billingClient.queryProductDetailsAsync(
+                queryProductDetailsParams,
+                (billingResult, fetchedProductDetailsList) -> {
+                    if (billingResult.getResponseCode() == BillingResponseCode.OK && fetchedProductDetailsList != null) {
+                        this.productDetailsList = fetchedProductDetailsList.getProductDetailsList();
+                        // Now that the list is populated, you can use it.
+                        // For example, find a specific product.
+                        if (!this.productDetailsList.isEmpty()) {
+                            this.productDetails = this.productDetailsList.get(0);
+                            // Any methods that require productDetails should be called from here.
+                        }
+                    }
+                });


The product details are fetched asynchronously, but there's no mechanism for the caller of queryProductDetails to know when the data is ready or if an error occurred. This can lead to race conditions where other methods (e.g., changeSubscriptionPlan) try to use productDetails before it's initialized. Consider using a listener, callback, or a reactive approach (like Flow or LiveData) to expose the result of this asynchronous operation.

gemini-code-assist · 2026-01-05T10:21:46Z

playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java

+                        // Now that the list is populated, you can use it.
+                        // For example, find a specific product.
+                        if (!this.productDetailsList.isEmpty()) {
+                            this.productDetails = this.productDetailsList.get(0);


Accessing the first element of the list with get(0) is unsafe because the list could be empty, which would cause an IndexOutOfBoundsException. You should always check if the list is empty before accessing elements. Furthermore, if you query for multiple products, you should iterate through the list to find the specific product you need rather than assuming it's the first one.

gemini-code-assist · 2026-01-05T10:21:46Z

playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java

+                billingClient.acknowledgePurchase(acknowledgePurchaseParams, (billingResult) -> {
+                    // Acknowledgment handled.
+                });


The result of the acknowledgePurchase call is ignored. It's crucial to check the billingResult to ensure the purchase was successfully acknowledged. If acknowledgement fails, Google will automatically refund the purchase after a few days. You should handle failures, for example by logging the error or implementing a retry mechanism.

billingClient.acknowledgePurchase(acknowledgePurchaseParams, (billingResult) -> { if (billingResult.getResponseCode() != BillingResponseCode.OK) { // Acknowledgment failed. Log the error and consider retrying. } });

gemini-code-assist · 2026-01-05T10:21:46Z

playbilling/src/main/AndroidManifest.xml

+<!--
+     Copyright 2026 The Android Open Source Project
+
+     Licensed under the Apache License, Version 2.0 (the "License");


Setting android:allowBackup="true" can pose a security risk, as it allows users to back up and restore application data via adb. For an application handling sensitive information like billing, it's recommended to disable this feature unless you have a specific need and have implemented a secure backup strategy.

Suggested change

Licensed under the Apache License, Version 2.0 (the "License");

android:allowBackup="false"

gemini-code-assist · 2026-01-05T10:21:46Z

playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java

+                    if (billingResult.getResponseCode() == BillingResponseCode.OK && billingConfig != null) {
+                        String countryCode = billingConfig.getCountryCode();
+                    } else {
+                        // TODO: Handle errors


The error path for getBillingConfigAsync contains a TODO comment. It's important to implement proper error handling, such as logging the error, to aid in debugging and ensure application stability.

add pbl snippets

9272c15

kumann-dev requested review from kkuan2011 and yrezgui as code owners January 5, 2026 10:18

kumann-dev and others added 2 commits January 5, 2026 10:21

Apply Spotless

55f5c09

fixed formatting issues

c770cbb

gemini-code-assist bot reviewed Jan 5, 2026

View reviewed changes

kumann-dev added 3 commits January 5, 2026 15:52

Merge branch 'pblv2' of https://github.com/android/snippets into pblv2

413dda7

added guava dependency

e85cb14

renamed playbillinglibrary directory to playbilling

69aa3b0

kumann-dev closed this Jan 8, 2026

kumann-dev deleted the pblv2 branch January 8, 2026 07:09

		@@ -0,0 +1,44 @@
		plugins {
		alias(libs.plugins.android.application)

	Licensed under the Apache License, Version 2.0 (the "License");
	android:allowBackup="false"

work-in-progress-do not review - add pbl snippets #758

work-in-progress-do not review - add pbl snippets #758

Uh oh!

Conversation

kumann-dev commented Jan 5, 2026

Uh oh!

snippet-bot bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Jan 5, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

snippet-bot bot commented Jan 5, 2026 •

edited

Loading