-
Notifications
You must be signed in to change notification settings - Fork 257
Removes perceived delay on initial watch face transfers #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @garanj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience for watch face transfers by addressing a perceived delay that occurred during the initial processing phase. By introducing a distinct "Preparing" state, the application now provides immediate visual feedback to the user, eliminating the impression of unresponsiveness and clearly communicating the ongoing background operations before the actual transfer begins. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively addresses the perceived UI freeze during watch face transfers by introducing a new PREPARING state. The implementation is solid, correctly updating the view model to emit this state before the background removal process and refactoring the UI to display it. The consolidation of SendingWatchFacePanel into a more generic TransferringWatchFacePanel is a good architectural improvement. I've identified a couple of issues in the new TransferringWatchFacePanel.kt file regarding its file path and a misuse of modifiers that should be corrected.
...ults/src/main/java/com/android/developers/androidify/customize/TransferringWatchFacePanel.kt
Outdated
Show resolved
Hide resolved
...ults/src/main/java/com/android/developers/androidify/customize/TransferringWatchFacePanel.kt
Show resolved
Hide resolved
|
Build broke because the enumeration is also used on the watch side, but use of this in |
When transferring a watch face, the Send to Watch button appears to freeze, particularly on first use, before transitioning to the Sending to Watch state.
This is because before sending the watch face, the background is removed with:
which can take a little time to initialize, if it hasn't been called before.
This PR adds a new watch face transmission state:
PREPARING. The send button is updated to reflect being in thePREPARINGstate immediately, so removing the user perception that the transmission has hung.Also a small number of other unrelated files have been modified as a result of running Spotless.