Skip to content

Conversation

@garanj
Copy link
Contributor

@garanj garanj commented Sep 22, 2025

When transferring a watch face, the Send to Watch button appears to freeze, particularly on first use, before transitioning to the Sending to Watch state.

This is because before sending the watch face, the background is removed with:

imageGenerationRepository.removeBackground(bitmap)

which can take a little time to initialize, if it hasn't been called before.

This PR adds a new watch face transmission state: PREPARING. The send button is updated to reflect being in the PREPARING state immediately, so removing the user perception that the transmission has hung.

Also a small number of other unrelated files have been modified as a result of running Spotless.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @garanj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user experience for watch face transfers by addressing a perceived delay that occurred during the initial processing phase. By introducing a distinct "Preparing" state, the application now provides immediate visual feedback to the user, eliminating the impression of unresponsiveness and clearly communicating the ongoing background operations before the actual transfer begins.

Highlights

  • Enhanced User Feedback: Introduced a new "PREPARING" state during watch face transfers to provide immediate visual feedback, preventing the perception of the application freezing during initial processing.
  • Unified Transfer UI: Replaced the dedicated SendingWatchFacePanel with a more generic TransferringWatchFacePanel to handle both the PREPARING and SENDING states, improving UI consistency and reusability.
  • Background Processing Indication: The imageGenerationRepository.removeBackground operation, which can cause initial delays, is now preceded by the PREPARING state, making the UI more responsive and transparent about ongoing background tasks.
  • Code Formatting: Minor formatting adjustments were applied across several files due to running Spotless, ensuring consistent code style.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses the perceived UI freeze during watch face transfers by introducing a new PREPARING state. The implementation is solid, correctly updating the view model to emit this state before the background removal process and refactoring the UI to display it. The consolidation of SendingWatchFacePanel into a more generic TransferringWatchFacePanel is a good architectural improvement. I've identified a couple of issues in the new TransferringWatchFacePanel.kt file regarding its file path and a misuse of modifiers that should be corrected.

@garanj
Copy link
Contributor Author

garanj commented Sep 22, 2025

Build broke because the enumeration is also used on the watch side, but use of this in when { } statements was no longer exhaustive.

@garanj garanj merged commit ec7b766 into android:main Sep 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants