Don't assign the normalEvaluator per default#4548
Open
JeroenBoersma wants to merge 2 commits intoalpinejs:mainfrom
Open
Don't assign the normalEvaluator per default#4548JeroenBoersma wants to merge 2 commits intoalpinejs:mainfrom
JeroenBoersma wants to merge 2 commits intoalpinejs:mainfrom
Conversation
Assigning the normal evaluator to theEvaluatorFunction means that it always needs to be exported. CSP doesn't use the normalEvaluator and should not include it in any build. alpinsjs/src/index.js always assigns the normalEvaluator manually and works as expected, and it isn't included anymore in the csp builds. * normalEvaluator also needed dependencies for unsafe functions which we don't want to include in the csp build
JeroenBoersma
added a commit
to JeroenBoersma/livewire
that referenced
this pull request
Feb 24, 2025
* I forgot to redirect some alpinejs to @/alpine * tested build on my alpinejs merge request alpinejs/alpine#4548
+ it would really helpfull for developers to have sourcemap files alongside of the js and minified js files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigning the normal evaluator to theEvaluatorFunction means that it always needs to be exported.
CSP doesn't use the normalEvaluator and should not include it in any build. alpinsjs/src/index.js always assigns the normalEvaluator manually and works as expected, and it isn't included anymore in the csp builds.