fix: restore dnd on focus pause#43
Merged
PranavPurwar merged 2 commits intoaload0:mainfrom Feb 1, 2026
Merged
Conversation
Added a call to restoreDND() after disabling focus mode to ensure Do Not Disturb settings are properly restored when focus mode ends.
- Always restore DND (remove conditional on shouldAutoStart). - Move vibration out of the sound-pref block and increase its duration to 2500ms so vibration occurs independently of sound settings
Member
|
i think we should only toggle the setting when the option is enabled. |
Contributor
Author
Thanks for your answer! According to the app settings, if the toggle is enabled it will |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on correctly restoring Do Not Disturb (DND) mode and refining the Pomodoro phase transition logic. The changes ensure DND is restored at appropriate times and that Pomodoro transitions are handled more clearly and efficiently.
Focus mode and Pomodoro logic improvements:
restoreDND()at the end of a session.transitionPomodoroPhase()if the session is in Pomodoro mode, improving clarity and correctness.Notification and feedback handling: