Fix heap overflow on computing parametrizations in non-shape-position case #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following code taken from
compute_parametrizations_non_shape_position_case:msolve/src/fglm/fglm_core.c
Lines 1281 to 1288 in 44fbc68
Line 1286 causes undefined behavior when
param->elim->lengthis less than or equal to 2. This is in particular the case forcyclic5-16.mswhen run withmsolve -f cyclic5-16.ms -d 4 -P 2 -l 2 -t 1 -v 2: on one of my machines, this causes a segmentation fault.This PR, as part of #214, fixes the issue.