Add rotation and position parameters to hand-controls.#5766
Add rotation and position parameters to hand-controls.#5766filandra wants to merge 1 commit intoaframevr:masterfrom
Conversation
The adjustment for Pico4 has been removed. It set the handModelOrientationX to -45 degrees, which now is the default value. As a result this adjustment is not neede anymore.
filandra
force-pushed
the
add-rotation-position-hand-controls
branch
from
f0df2a7 to
b64fbe2
Compare
|
Thanks. If any rotation is needed the rotation should be handled internally or |
|
@dmarcos sorry for the delay - the holidays were very busy hahah. What do you mean by internally? Should it be handled in some other module? I figured that I would place the rotation handling into the same place where it was being already modified previously. |
|
@filandra This means removing offSetRotation offSetPosition properties you added, put back the offset directly in radians inline in the code, so Math.PI / 4 for everything. |
|
@vincentfretin Well the whole point of the PR is to add the ability to set custom rotation and position. If not here, where should this logic be added? |
|
The rotation is wrong on all Quest headsets right? After you fix the rotation inline in the component, why would you need to customize it? |
|
Yeah we should just fix the rotation. No need of a public API |
4 participants
Description:
Added the ability to set the rotation and position of hand-controls.
Default rotation and position is aligned with Meta Quest Controllers.
The adjustment for Pico4 has been removed.
It set the handModelOrientationX to -45 degrees, which now is the default value. As a result this adjustment is not needed anymore.