Sre pr review #3125
Closed
Sre pr review #3125
+16
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syncs the deeplake header with the indra optimization that eliminates shared_ptr atomic reference counting in the get_range_data() hot path. Changes: - Add buffer_cache_ and offsets_cache_ members for zero-copy access - Update initialize_single_range signature to accept source_arr This header is a mirror of indra/cpp/nd/string_array_holder.hpp. The actual implementation is in .ext/deeplake_api/ via the static library. Co-Authored-By: Claude Opus 4.5 <[email protected]>
* add claude pr review * edits * edits * test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Impact
Description
Things to be aware of
Things to worry about
Additional Context