Update form-field-label-descriptive-cc0f0a.md#2345
Open
sage-putnam wants to merge 5 commits intodevelopfrom
Open
Update form-field-label-descriptive-cc0f0a.md#2345sage-putnam wants to merge 5 commits intodevelopfrom
sage-putnam wants to merge 5 commits intodevelopfrom
Conversation
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
sage-putnam
requested review from
WilcoFiers,
colabottles,
kengdoj and
sujisreerama
sage-putnam
added
Rule Update
kengdoj
reviewed
Aug 28, 2025
|
|
||
| ## Expectation 2 | ||
|
|
||
| Each test target, together with its [visual context][], describes the purpose of the associated element. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Each test target, together with its [visual context][], describes the purpose of the associated element. | |
| Each test target's label, together with its [visual context][], describes the purpose of the associated element. |
Collaborator
Author
There was a problem hiding this comment.
As discussed in today's meeting, I'll be removing this and refactoring expectation 1 into two separate expectations instead. We will still need to come up with a better definition for label, however.
colabottles
approved these changes
Sep 26, 2025
7 tasks
WilcoFiers
requested changes
Oct 9, 2025
|
|
||
| #### Passed Example 1 | ||
|
|
||
| The `label` element is a [programmatic label][] of the `input` element and describes it. |
Member
There was a problem hiding this comment.
Suggested change
| The `label` element has a visible relationship with the `input` element and describes it. |
|
|
||
| #### Passed Example 5 | ||
|
|
||
| The `label` elements are [programmatic labels][programmatic label] of their respective `input` elements. The `label` elements, are not descriptive enough (because they are repeated over several fields). However, the headings provide a [visual context][] that differentiates the purpose of the otherwise identically named form fields. Within their [visual context][], the `label` elements are descriptive of their respective `input` elements. |
Member
There was a problem hiding this comment.
Suggested change
| The `label` elements visually related to their respective `input` elements. The `label` elements, are not descriptive enough (because they are repeated over several fields). However, the headings also works as a visual label that differentiates the purpose of the otherwise identically named form fields. |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| The `label` elements are visually related to their respective `input` elements. The `label` elements are not descriptive enough (because they are repeated over several fields). However, the headings also provide visual labels that differentiate the purpose of the otherwise identically named form fields. |
Comment on lines
244
to
254
| #### Inapplicable Example 2 | ||
|
|
||
| The `label` element is not [visible][]. | ||
|
|
||
| ```html | ||
| <html lang="en"> | ||
| <label for="fname" style="position: absolute; left: -9999px;">First name:</label> | ||
| <label aria-hidden="true">First name:</label> | ||
| <input id="fname" type="text" name="fname" /> | ||
| </html> | ||
| ``` |
Member
There was a problem hiding this comment.
This now passes. I think we can delete this example.
Collaborator
There was a problem hiding this comment.
and where both the element and the [programmatic label][] are [visible][].
the programmatic label is still not visible, so it's still inapplicable.
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the following survey action items in regards to rule cc0f0a - Form field label is descriptive:
The remaining action item reads "Visual context definition is somewhat ambiguous and vague and needs to be improved." @WilcoFiers, are you able to speak more on the ambiguity we should improve on?
I believe this was previously assigned to @colabottles, and I'm happy to collaborate or cede these changes to you if you're farther along here!
Finally, as this is my first PR or direct change to the repo, please let me know if there is anything I've missed process-wise. I've chosen a 1-week review, but I can change that if changing the visual context definition increases the complexity.
Closes issue(s):
Need for Call for Review:
This will require a 1 week Call for Review
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve