Plugin Directory: Use secondary style for "Discard" release button in confirmation UI#532
Open
manhphuc wants to merge 2 commits intoWordPress:trunkfrom
Open
Plugin Directory: Use secondary style for "Discard" release button in confirmation UI#532manhphuc wants to merge 2 commits intoWordPress:trunkfrom
manhphuc wants to merge 2 commits intoWordPress:trunkfrom
Conversation
…econdary to match design expectations. Fixes #8142.
…tton. Fixes #8142.
Author
|
Thanks for the feedback! You were absolutely right — my initial change only updated the class and didn't adjust the visual styling. I've updated the PR to:
The “Discard” button now reflects the intended secondary hierarchy in the release confirmation dialog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change styles the destructive “Discard” release button as a secondary button, so it no longer appears the same as the primary “Confirm” action.
It keeps the existing behaviour intact and only adjusts the visual hierarchy of the actions.
Fixes: https://meta.trac.wordpress.org/ticket/8142